linux-kernel - Re: [PATCH FOR REFERENCE v4 7/7] gpu: nova-core: use the kernel `register!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cb580e1-3d50-42df-9050-b4439c83465c@nvidia.com>
Date: Tue, 27 Jan 2026 18:57:56 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Danilo Krummrich <dakr@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Daniel Almeida <daniel.almeida@...labora.com>,
 Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>
Cc: Yury Norov <yury.norov@...il.com>, Alistair Popple <apopple@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Edwin Peer <epeer@...dia.com>, Eliot Courtney <ecourtney@...dia.com>,
 Dirk Behme <dirk.behme@...bosch.com>, Steven Price <steven.price@....com>,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH FOR REFERENCE v4 7/7] gpu: nova-core: use the kernel
 `register!` macro

On 1/27/26 6:37 PM, Alexandre Courbot wrote:
> Replace the nova-core internal `register!` macro by the one defined in
> the `kernel` crate and remove our own private implementations.
> 
> Tested-by: Dirk Behme <dirk.behme@...bosch.com>
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>  drivers/gpu/nova-core/falcon.rs           | 175 +++----
>  drivers/gpu/nova-core/falcon/gsp.rs       |  12 +-
>  drivers/gpu/nova-core/falcon/hal/ga102.rs |  15 +-
>  drivers/gpu/nova-core/falcon/sec2.rs      |  13 +-
>  drivers/gpu/nova-core/fb/hal/ga100.rs     |  17 +-
>  drivers/gpu/nova-core/fb/hal/tu102.rs     |   2 +-
>  drivers/gpu/nova-core/gpu.rs              |  31 +-
>  drivers/gpu/nova-core/gsp/cmdq.rs         |   4 +-
>  drivers/gpu/nova-core/regs.rs             | 494 +++++++++++---------
>  drivers/gpu/nova-core/regs/macros.rs      | 739 ------------------------------
>  10 files changed, 397 insertions(+), 1105 deletions(-)

Reading through this, it does look like an across the board improvement
in readability in nova-core. Great!

thanks,
-- 
John Hubbard