linux-kernel - Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26c4e0b7f9c25f405401288d13fc7e5097e9c7f5@intel.com>
Date: Wed, 28 Jan 2026 17:23:51 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Atharva Tiwari <atharvatiwarilinuxdev@...il.com>
Cc: Atharva Tiwari <atharvatiwarilinuxdev@...il.com>, Ard Biesheuvel
 <ardb@...nel.org>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Thomas
 Zimmermann <tzimmermann@...e.de>, Javier Martinez Canillas
 <javierm@...hat.com>, "Borislav Petkov (AMD)" <bp@...en8.de>, Lenny
 Szubowicz <lszubowi@...hat.com>, Francesco Pompo
 <francescopompo2@...il.com>, linux-efi@...r.kernel.org,
 linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's

On Wed, 28 Jan 2026, Atharva Tiwari <atharvatiwarilinuxdev@...il.com> wrote:
> Disable display on iMacs, as they can't do link training
> on the internal display.

I'd expand on that a bit, based on the previous discussion.

>
> (tested on iMac20,1)
>
> Signed-off-by: Atharva Tiwari <atharvatiwarilinuxdev@...il.com>

I can't test this, but if nobody chimes in to oppose, I'll take it.

Reviewed-by: Jani Nikula <jani.nikula@...el.com>


> ---
>  .../gpu/drm/i915/display/intel_display_device.c    | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 1170afaa8680..b1fec1018d7e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -3,6 +3,7 @@
>   * Copyright © 2023 Intel Corporation
>   */
>  
> +#include <linux/dmi.h>
>  #include <linux/pci.h>
>  
>  #include <drm/drm_color_mgmt.h>
> @@ -1435,7 +1436,18 @@ static bool has_no_display(struct pci_dev *pdev)
>  		{}
>  	};
>  
> -	return pci_match_id(ids, pdev);
> +	static const struct dmi_system_id dmi_ids[] = {
> +		{
> +			.ident = "Apple Inc. iMac",
> +			.matches = {
> +				DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Apple Inc."),
> +				DMI_MATCH(DMI_PRODUCT_NAME, "iMac"),
> +			}
> +		},
> +		{}
> +	};
> +
> +	return pci_match_id(ids, pdev) || dmi_check_system(dmi_ids);
>  }
>  
>  #define INTEL_DISPLAY_DEVICE(_id, _desc) { .devid = (_id), .desc = (_desc) }

-- 
Jani Nikula, Intel