linux-kernel - Re: [PATCH v4 6/7] sample: rust: pci: use `register!` macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DG0C89D4BIM4.2ODXV9R5R2E52@garyguo.net>
Date: Wed, 28 Jan 2026 15:46:25 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Alexandre Courbot" <acourbot@...dia.com>, "Zhi Wang" <zhiw@...dia.com>
Cc: "Danilo Krummrich" <dakr@...nel.org>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "Daniel Almeida" <daniel.almeida@...labora.com>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 "Gary Guo" <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Trevor Gross" <tmgross@...ch.edu>,
 "Yury Norov" <yury.norov@...il.com>, "John Hubbard" <jhubbard@...dia.com>,
 "Alistair Popple" <apopple@...dia.com>, "Joel Fernandes"
 <joelagnelf@...dia.com>, "Timur Tabi" <ttabi@...dia.com>, "Edwin Peer"
 <epeer@...dia.com>, "Eliot Courtney" <ecourtney@...dia.com>, "Dirk Behme"
 <dirk.behme@...bosch.com>, "Steven Price" <steven.price@....com>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 6/7] sample: rust: pci: use `register!` macro

On Wed Jan 28, 2026 at 1:27 PM GMT, Alexandre Courbot wrote:
> On Wed Jan 28, 2026 at 9:35 PM JST, Zhi Wang wrote:
>> On Wed, 28 Jan 2026 11:37:32 +0900
>> Alexandre Courbot <acourbot@...dia.com> wrote:
>>
>>> Convert the direct IO accesses to properly defined registers.
>>> 
>>
>> Tested-by: Zhi Wang <zhiw@...dia.com>
>>
>> I can see the correct value of the registers read by the sample driver
>> from the demesg. 
>
> Thanks!
>
>>
>> Additionally, Clippy was complaining about unnecssary unsafe blocks and
>> can be fixed by: (I haven't fully gone through the code, just applied this
>> for getting rid of the warnnings.)
>
> This is because `Bounded::__new` has become unsafe in `rust-next` ; this
> is not reflected in `driver-core-next` yet, but won't appear in -rc1.

Any reason that you send the patch based on driver-core-next, instead of
linux-next? You won't have the issue if this is based on linux-next.

Best,
Gary