linux-kernel - Re: [PATCH v1 1/1] serial: 8250_port: Drop duplicate NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXou9dAiTdhzuqrn@smile.fi.intel.com>
Date: Wed, 28 Jan 2026 17:44:53 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Ilpo JÃ¤rvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-serial <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_port: Drop duplicate NULL check

On Wed, Jan 28, 2026 at 05:09:31PM +0200, Ilpo JÃ¤rvinen wrote:
> On Wed, 28 Jan 2026, Andy Shevchenko wrote:

...

> > -	if (up->dma)
> > -		serial8250_release_dma(up);
> > +	serial8250_release_dma(up);
> > +	up->dma = NULL;
> 
> Seems reasonable safeguard,

Note, 8250_omap does the same for last 3 years.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Thanks!


-- 
With Best Regards,
Andy Shevchenko