linux-kernel - Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXov8c4RSs2f7yAL@wunner.de>
Date: Wed, 28 Jan 2026 16:49:05 +0100
From: Lukas Wunner <lukas@...ner.de>
To: Atharva Tiwari <atharvatiwarilinuxdev@...il.com>
Cc: Ard Biesheuvel <ardb@...nel.org>,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
	Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Javier Martinez Canillas <javierm@...hat.com>,
	"Borislav Petkov (AMD)" <bp@...en8.de>,
	Lenny Szubowicz <lszubowi@...hat.com>,
	Francesco Pompo <francescopompo2@...il.com>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's

On Wed, Jan 28, 2026 at 02:58:38PM +0000, Atharva Tiwari wrote:
> Disable display on iMacs, as they can't do link training
> on the internal display.
> 
> (tested on iMac20,1)

So with your patch the screen is black on those iMacs?
I don't quite understand why that would be desirable.

What happens without this patch?  Something worse than a black screen?
This needs to be explained in the commit message so that reviewers
understand why the patch is needed.

I also don't understand why this patch follows the EFI set_os one.
What's the connection between those two patches?  If there is none,
they shouldn't be submitted as a series but as two individual patches.

Thanks,

Lukas