linux-kernel - Re: [PATCH net v4 0/3] net: liquidio: Fix memory leaks in setup_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260128165423.0e1b0cab@kmaincent-XPS-13-7390>
Date: Wed, 28 Jan 2026 16:54:23 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Zilin Guan <zilin@....edu.cn>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, horms@...nel.org, jianhao.xu@....edu.cn,
 marco.crivellari@...e.com, vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net v4 0/3] net: liquidio: Fix memory leaks in
 setup_nic_devices()

On Wed, 28 Jan 2026 15:44:37 +0000
Zilin Guan <zilin@....edu.cn> wrote:

> This series fixes memory leaks in the initialization paths of the 
> NIC devices.
> 
> Patch 1 moves the initialization of oct->props[i].netdev before queue 
> setup calls. This ensures that if queue setup fails, the cleanup function 
> can find and free the allocated netdev. It also initializes lio->oct_dev 
> early to prevent a crash in the cleanup path.
> 
> Patch 2 fixes an off-by-one error in the PF cleanup loop. It ensures
> the current device index is cleaned up and correctly handles the 
> post-loop devlink_alloc failure case.
> 
> Patch 3 fixes the same off-by-one error in the VF cleanup loop.

For the series:
Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>

Thank you!
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com