linux-kernel - Re: [PATCH v2] fs: dcache: fix typo in enum d_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6eysg7ylje35of4z6hjkx4m5xbclll7tpmyy5tzegrvpejdfg6@eqean3xckhs4>
Date: Wed, 28 Jan 2026 17:22:36 +0100
From: Jan Kara <jack@...e.cz>
To: Chelsy Ratnawat <chelsyratnawat2001@...il.com>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs: dcache: fix typo in enum d_walk_ret comment

On Wed 28-01-26 06:31:50, Chelsy Ratnawat wrote:
> Fix minor spelling and indentation errors in the
> documentation comments.
> 
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@...il.com>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/dcache.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/dcache.c b/fs/dcache.c
> index 66dd1bb830d1..f995c25fb52b 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -1298,8 +1298,8 @@ void shrink_dcache_sb(struct super_block *sb)
>  EXPORT_SYMBOL(shrink_dcache_sb);
>  
>  /**
> - * enum d_walk_ret - action to talke during tree walk
> - * @D_WALK_CONTINUE:	contrinue walk
> + * enum d_walk_ret - action to take during tree walk
> + * @D_WALK_CONTINUE:	continue walk
>   * @D_WALK_QUIT:	quit walk
>   * @D_WALK_NORETRY:	quit when retry is needed
>   * @D_WALK_SKIP:	skip this dentry and its children
> @@ -1722,7 +1722,7 @@ void d_invalidate(struct dentry *dentry)
>  EXPORT_SYMBOL(d_invalidate);
>  
>  /**
> - * __d_alloc	-	allocate a dcache entry
> + * __d_alloc - allocate a dcache entry
>   * @sb: filesystem it will belong to
>   * @name: qstr of the name
>   *
> @@ -1806,7 +1806,7 @@ static struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
>  }
>  
>  /**
> - * d_alloc	-	allocate a dcache entry
> + * d_alloc - allocate a dcache entry
>   * @parent: parent of entry to allocate
>   * @name: qstr of the name
>   *
> @@ -2546,7 +2546,7 @@ static void __d_rehash(struct dentry *entry)
>  }
>  
>  /**
> - * d_rehash	- add an entry back to the hash
> + * d_rehash - add an entry back to the hash
>   * @entry: dentry to add to the hash
>   *
>   * Adds a dentry to the hash according to its name.
> -- 
> 2.47.3
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR