linux-kernel - Re: [PATCH] ext4: fast commit: make s_fc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176962347640.1138505.15539456502185156934.b4-ty@mit.edu>
Date: Wed, 28 Jan 2026 13:05:04 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: Jan Kara <jack@...e.cz>, Andreas Dilger <adilger.kernel@...ger.ca>,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Li Chen <me@...ux.beauty>
Cc: "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH] ext4: fast commit: make s_fc_lock reclaim-safe


On Tue, 06 Jan 2026 20:06:21 +0800, Li Chen wrote:
> s_fc_lock can be acquired from inode eviction and thus is
> reclaim unsafe. Since the fast commit path holds s_fc_lock while writing
> the commit log, allocations under the lock can enter reclaim and invert
> the lock order with fs_reclaim. Add ext4_fc_lock()/ext4_fc_unlock()
> helpers which acquire s_fc_lock under memalloc_nofs_save()/restore()
> context and use them everywhere so allocations under the lock cannot
> recurse into filesystem reclaim.
> 
> [...]

Applied, thanks!

[1/1] ext4: fast commit: make s_fc_lock reclaim-safe
      commit: 491f2927ae097e2d405afe0b3fe841931ab8aad2

Best regards,
-- 
Theodore Ts'o <tytso@....edu>