linux-kernel - [PATCH RFC 11/12] dmaengine: fsl-edma: use local soff/doff variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260128-dma_ll_comlib-v1-11-1b1fa2c671f9@nxp.com>
Date: Wed, 28 Jan 2026 13:05:30 -0500
From: Frank Li <Frank.Li@....com>
To: Vinod Koul <vkoul@...nel.org>
Cc: linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org, 
 imx@...ts.linux.dev, joy.zou@....com, Frank Li <Frank.Li@....com>
Subject: [PATCH RFC 11/12] dmaengine: fsl-edma: use local soff/doff
 variables

Introduce local soff and doff variables (and related fields) so that memcpy
set_lli() handling matches the sg and cyclic cases.

Prepare the fsl-edma driver for moving prep_slave_{sg,cyclic} into the
common linked-list library.

Signed-off-by: Frank Li <Frank.Li@....com>
---
 drivers/dma/fsl-edma-common.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index ff1ef067cfcffef876eefd30c62d630c77ac537a..fdac0518316914d59df592ad26f6000d2034bcb9 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -517,6 +517,10 @@ static int fsl_edma_set_lli(struct dma_ll_desc *desc, u32 idx,
 	struct fsl_edma_chan *fsl_chan = to_fsl_edma_chan(chan);
 	void *tcd = desc->its[idx].vaddr;
 	u32 src_bus_width, dst_bus_width;
+	bool disable_req;
+	u32 soff, doff;
+	u32 nbytes;
+	u16 iter;
 
 	/* Memory to memory */
 	if (!config) {
@@ -524,6 +528,12 @@ static int fsl_edma_set_lli(struct dma_ll_desc *desc, u32 idx,
 		dst_bus_width = min_t(u32, DMA_SLAVE_BUSWIDTH_32_BYTES, 1 << (ffs(dst) - 1));
 
 		fsl_chan->is_sw = true;
+
+		soff = src_bus_width;
+		doff = dst_bus_width;
+		iter = 1;
+		disable_req = true;
+		nbytes = len;
 	}
 
 	if (fsl_edma_drvflags(fsl_chan) & FSL_EDMA_DRV_MEM_REMOTE)
@@ -532,7 +542,7 @@ static int fsl_edma_set_lli(struct dma_ll_desc *desc, u32 idx,
 	/* To match with copy_align and max_seg_size so 1 tcd is enough */
 	__fsl_edma_fill_tcd(fsl_chan, tcd, src, dst,
 			    fsl_edma_get_tcd_attr(src_bus_width, dst_bus_width),
-			    src_bus_width, len, 0, 1, 1, dst_bus_width, irq, true);
+			    soff, nbytes, 0, iter, iter, doff, irq, disable_req);
 
 	return 0;
 }

-- 
2.34.1