linux-kernel - Re: [PATCH RESEND v3 2/2] arm64: dts: realtek: Add Kent SoC and EVB device trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3df3e1d-0aa7-4161-a7ae-0a2dfbd34cd5@kernel.org>
Date: Wed, 28 Jan 2026 19:41:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yu-Chun Lin <eleanor15x@...il.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, james.tai@...ltek.com, soc@...ts.linux.dev
Cc: afaerber@...e.de, arnd@...db.de, linux-arm-kernel@...ts.infradead.org,
 linux-realtek-soc@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cy.huang@...ltek.com,
 stanley_chang@...ltek.com, eleanor.lin@...ltek.com
Subject: Re: [PATCH RESEND v3 2/2] arm64: dts: realtek: Add Kent SoC and EVB
 device trees

On 27/01/2026 08:14, Yu-Chun Lin wrote:
> +
> +	reserved_memory: reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;

Earlier (I removed it from the context) nodes are not ordered according
to DTS coding style.

> +
> +		linux,cma {
> +			compatible = "shared-dma-pool";
> +			alignment = <0x0 0x400000>;
> +			alloc-ranges = <0x0 0x0 0x0 0x20000000>;
> +			size = <0x0 0x2000000>;
> +			reusable;
> +			linux,cma-default;
> +		};
> +	};
> +
> +	cpu_opps: opp-table-cpu {

It is odd to see this on the board level. This really is SoC or (in your
case) SoC variant layer.

Same for other DTSI.

These two issues however are not critical and I did not see other
worrying things, so I would merge it.

Arnd:

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof