linux-kernel - Re: [PATCH] phy: PHY_GOOGLE_USB should depend on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e955868c06547ac62d34d594d45dd07aa19e361b.camel@linaro.org>
Date: Wed, 28 Jan 2026 20:03:25 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Vinod Koul
 <vkoul@...nel.org>,  Neil Armstrong <neil.armstrong@...aro.org>, Peter
 Griffin <peter.griffin@...aro.org>, Tudor Ambarus	
 <tudor.ambarus@...aro.org>, Naveen Kumar <mnkumar@...gle.com>, Roy Luo	
 <royluo@...gle.com>, Joy Chakraborty <joychakr@...gle.com>, Arnd Bergmann	
 <arnd@...db.de>
Cc: linux-phy@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: PHY_GOOGLE_USB should depend on ARCH_GOOGLE

Hi Geert,

On Tue, 2026-01-27 at 20:12 +0100, Geert Uytterhoeven wrote:
> The Google Tensor SoC USB PHY is only present on Google Tensor G5
> (Laguna) SoCs.  Hence add a dependency on ARCH_GOOGLE, to prevent asking
> the user about this driver when configuring a kernel without Google
> Tensor SoC support.
> 
> Fixes: cbce66669c82ee9a ("phy: Add Google Tensor SoC USB PHY driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> ARCH_GOOGLE is not yet upstream, but that doesn't hurt.

I can see your point, and have no objection, but for context, Greg
had asked to not add dependencies on a config option that might or
might not get added in the future - ARCH_GOOGLE:

https://lore.kernel.org/all/2025121728-reliably-crabgrass-2601@gregkh/

Maybe an alternative would be to make it default=n, and change that
default once ARCH_GOOGLE gets added?


Cheers,
Andre'

> ---
>  drivers/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 142e7b0ef2efb920..3ceda9a20d571038 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -49,6 +49,7 @@ config GENERIC_PHY_MIPI_DPHY
>  
>  config PHY_GOOGLE_USB
>  	tristate "Google Tensor SoC USB PHY driver"
> +	depends on ARCH_GOOGLE || COMPILE_TEST
>  	select GENERIC_PHY
>  	help
>  	  Enable support for the USB PHY on Google Tensor SoCs, starting with