linux-kernel - Re: [PATCH v2 0/2] mtd: devices: Qualcomm SCM storage support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <njrzcyhdkohsmnlisdzu25b6obqotjjrzlrs42jhq5bhlz6qco@mdk5blghdqbc>
Date: Wed, 28 Jan 2026 14:31:33 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Junhao Xie <bigfoot@...xa.com>, Konrad Dybcio <konradybcio@...nel.org>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org, 
	Xilin Wu <sophon@...xa.com>
Subject: Re: [PATCH v2 0/2] mtd: devices: Qualcomm SCM storage support

On Wed, Jan 28, 2026 at 03:13:59PM +0100, Miquel Raynal wrote:
> Hello,
> 
> >> Junhao Xie (2):
> >>       firmware: qcom: scm: Add SCM storage interface support
> >>       mtd: devices: Add Qualcomm SCM storage driver
> >> 
> >>  drivers/firmware/qcom/qcom_scm.c       | 161 ++++++++++++++++++++
> >>  drivers/firmware/qcom/qcom_scm.h       |   3 +
> >>  drivers/mtd/devices/Kconfig            |  17 +++
> >>  drivers/mtd/devices/Makefile           |   1 +
> >>  drivers/mtd/devices/qcom_scm_storage.c | 265 +++++++++++++++++++++++++++++++++
> >>  include/linux/firmware/qcom/qcom_scm.h |  34 +++++
> >>  6 files changed, 481 insertions(+)
> >> ---
> >> base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377
> >
> > This is 6.19-rc7, please rebase on linux-next/master (the series
> > doesn't currently apply because this base is essentially a full release
> > behind)
> 
> If I may, I even skipped the mail entirely because it was not about mtd
> in the end. There is a single big patch labelled "firmware: qcom:". I
> believe the series would better be split in smaller chunks. Typically
> one for the storage support and another one for the firmware part, at
> least.
> 

The firmware patch adds wrappers for the secure world interface, which
without the MTD driver will lack consumers of the API - i.e. I'd prefer
not to pick that part, or parts thereof, alone.

So I think it does make sense to introduce the two parts together in one
series (if you have any requests for splitting the MTD patch up in any
way I have no objections).

This leaves us with the practical problem of getting it merged, which I
believe would best be handled by me picking the firmware patch and
sharing this in an immutable branch with you, once we're happy with the
set (which won't be for 6.20).

I hope you're okay with such plan?

Regards,
Bjorn

> Thanks,
> Miquèl