linux-kernel - Re: [External] Re: [PATCH] fuse: set ff->flock only on success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4dvsfQGAmoG_y1FUMFFVG0SeWZRCN6aseturcWLpEPZKjQ0A@mail.gmail.com>
Date: Wed, 28 Jan 2026 11:35:49 +0800
From: Zhang Tianci <zhangtianci.1997@...edance.com>
To: Miklos Szeredi <miklos@...redi.hu>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	xieyongji@...edance.com, Li Yichao <liyichao.1@...edance.com>
Subject: Re: [External] Re: [PATCH] fuse: set ff->flock only on success

Hi Miklos,

On Tue, Jan 27, 2026 at 5:58 PM Miklos Szeredi <miklos@...redi.hu> wrote:
>
> On Thu, 25 Dec 2025 at 12:12, Zhang Tianci
> <zhangtianci.1997@...edance.com> wrote:
> >
> > If FUSE_SETLK fails (e.g., due to EWOULDBLOCK), we shall not set
> > FUSE_RELEASE_FLOCK_UNLOCK in fuse_file_release().
>
> It's not clear if this is an optimization, a correctness fix or neither?

I think it's an optimization, If FUSE_SETLK failed, FUSEdaemon  will
not record this lock, so in
FUSE_RELEASE operation, FUSEdaemon will perform an unnecessary lock
owner lookup.

Thanks,
Tianci