linux-kernel - Re: [PATCH v3 3/4] staging: rtl8723bs: replace skb allocation wrappers and fix build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXqIAzZBIx04GTOJ@smile.fi.intel.com>
Date: Thu, 29 Jan 2026 00:04:51 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Minu Jin <s9430939@...er.com>
Cc: gregkh@...uxfoundation.org, hansg@...nel.org, dan.carpenter@...aro.org,
	trohan2000@...il.com, andy@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	straube.linux@...il.com
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: replace skb allocation
 wrappers and fix build

On Wed, Jan 28, 2026 at 11:09:53PM +0900, Minu Jin wrote:
> Replace the wrapper functions rtw_skb_alloc and rtw_skb_copy with
> kernel APIs __dev_alloc_skb and skb_copy.

We refer to the functions as func() (note the parentheses).

...

> Additionally, this patch restores the definitions of _rtw_malloc and
> _rtw_zmalloc that were prematurely removed in previous commits.

Huh?! Don't remove them if driver doesn't compile.

> This ensures that the driver remains buildable, fixing git bisect issues
> until all wrappers are fully migrated and can be safely removed in
> the final cleanup step.

-- 
With Best Regards,
Andy Shevchenko