linux-kernel - Re: [PATCH v6 2/9] dt-bindings: display: add verisilicon,dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXqUbDw45ulf8c+s@x1>
Date: Wed, 28 Jan 2026 14:57:48 -0800
From: Drew Fustini <fustini@...nel.org>
To: Icenowy Zheng <zhengxingda@...as.ac.cn>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Guo Ren <guoren@...nel.org>,
	Fu Wei <wefu@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>,
	Dmitry Baryshkov <lumag@...nel.org>,
	Michal Wilczynski <m.wilczynski@...sung.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Han Gao <rabenda.cn@...il.com>, Yao Zi <ziyao@...root.org>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
	Icenowy Zheng <uwu@...nowy.me>
Subject: Re: [PATCH v6 2/9] dt-bindings: display: add verisilicon,dc

On Wed, Jan 28, 2026 at 12:34:41PM -0800, Drew Fustini wrote:
> On Fri, Jan 23, 2026 at 05:28:23PM +0800, Icenowy Zheng wrote:
> > From: Icenowy Zheng <uwu@...nowy.me>
> > 
> > Verisilicon has a series of display controllers prefixed with DC and
> > with self-identification facility like their GC series GPUs.
> > 
> > Add a device tree binding for it.
> > 
> > Depends on the specific DC model, it can have either one or two display
> > outputs, and each display output could be set to DPI signal or "DP"
> > signal (which seems to be some plain parallel bus to HDMI controllers).
> > 
> > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> > Signed-off-by: Icenowy Zheng <zhengxingda@...as.ac.cn>
> > Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> > Changes in v6:
> > - Added Rob's R-b.
> > 
> > Changes in v5:
> > - Dropped the requirement of port@0.
> > - Dropped the if clause for TH1520, which seems to be not needed because
> >   of implicit DT binding rules.
> > 
> > Changes in v4:
> > - Added a comment for "verisilicon,dc" that says the ID/revision is
> >   discoverable via registers.
> > - Removed clock minItems constraint w/o specific compatible strings.
> > 
> > Changes in v3:
> > - Added SoC-specific compatible string, and arm the binding with clock /
> >   port checking for the specific SoC (with a 2-output DC).
> > 
> > Changes in v2:
> > - Fixed misspelt "versilicon" in title.
> > - Moved minItems in clock properties to be earlier than items.
> > - Re-aligned multi-line clocks and resets in example.
> > 
> >  .../bindings/display/verisilicon,dc.yaml      | 122 ++++++++++++++++++
> >  1 file changed, 122 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/verisilicon,dc.yaml
> 
> I've applied the bindings patches (1, 2, 4) to thead-dt-for-next as well
> so that 'make W=1 dtbs_check' won't break for the next release of
> linux-next.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/log/?h=thead-dt-for-next
> 
> Please see my reply to patch 1 for the rest of my message.

I've dropped the yaml patches from thead-dt-for-next based on Conor's
advice. Patches 1, 2 and 4 can go through drm.

Drew