linux-kernel - [PATCH] iio: addac: ad74115: Add missing check for device_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260128043040.2260887-1-nichen@iscas.ac.cn>
Date: Wed, 28 Jan 2026 12:30:40 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: lars@...afoo.de,
	Michael.Hennerich@...log.com,
	cosmin.tanislav@...log.com,
	jic23@...nel.org,
	dlechner@...libre.com,
	nuno.sa@...log.com,
	andy@...nel.org
Cc: linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH] iio: addac: ad74115: Add missing check for device_property_read_u32_array

Add check for the return value of device_property_read_u32_array() and
return the error if it fails in order to catch the error.

Signed-off-by: Chen Ni <nichen@...as.ac.cn>
---
 drivers/iio/addac/ad74115.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
index f8b04d86b01f..d0d6c0575ff1 100644
--- a/drivers/iio/addac/ad74115.c
+++ b/drivers/iio/addac/ad74115.c
@@ -1515,8 +1515,12 @@ static int ad74115_setup_adc_conv2_range(struct ad74115_state *st)
 	};
 	struct device *dev = &st->spi->dev;
 	unsigned int i;
+	int ret;
 
-	device_property_read_u32_array(dev, prop_name, vals, 2);
+	ret = device_property_read_u32_array(dev, prop_name, vals, 2);
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to read %s prop\n",
+				     prop_name);
 
 	for (i = 0; i < tbl_len; i++)
 		if (vals[0] == ad74115_adc_range_tbl[i][0] &&
-- 
2.25.1