linux-kernel - RE: [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9496A39912A88B4C1A6491799091A@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Wed, 28 Jan 2026 06:02:53 +0000
From: Bough Chen <haibo.chen@....com>
To: Chen Ni <nichen@...as.ac.cn>, "jic23@...nel.org" <jic23@...nel.org>,
	"dlechner@...libre.com" <dlechner@...libre.com>, "nuno.sa@...log.com"
	<nuno.sa@...log.com>, "andy@...nel.org" <andy@...nel.org>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: adc: vf610: Add missing check for
 device_property_read_u32_array

> -----Original Message-----
> From: Chen Ni <nichen@...as.ac.cn>
> Sent: 2026年1月28日 12:27
> To: Bough Chen <haibo.chen@....com>; jic23@...nel.org;
> dlechner@...libre.com; nuno.sa@...log.com; andy@...nel.org
> Cc: linux-iio@...r.kernel.org; imx@...ts.linux.dev; linux-kernel@...r.kernel.org;
> Chen Ni <nichen@...as.ac.cn>
> Subject: [PATCH] iio: adc: vf610: Add missing check for
> device_property_read_u32_array
> 
> Add check for the return value of device_property_read_u32_array() and return
> the error if it fails in order to catch the error.

Reviewed-by: Haibo Chen <haibo.chen@....com>

Best Regards
Haibo Chen
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/iio/adc/vf610_adc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
> d7182ed0d2a7..d53723ccc5b2 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -871,7 +871,10 @@ static int vf610_adc_probe(struct platform_device
> *pdev)
> 
>  	info->vref_uv = regulator_get_voltage(info->vref);
> 
> -	device_property_read_u32_array(dev, "fsl,adck-max-frequency",
> info->max_adck_rate, 3);
> +	ret = device_property_read_u32_array(dev, "fsl,adck-max-frequency",
> +					     info->max_adck_rate, 3);
> +	if (ret)
> +		return ret;
> 
>  	info->adc_feature.default_sample_time = DEFAULT_SAMPLE_TIME;
>  	device_property_read_u32(dev, "min-sample-time",
> &info->adc_feature.default_sample_time);
> --
> 2.25.1