[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <DFZZW8ALVDW0.366DKMF7NGUYT@gmail.com>
Date: Wed, 28 Jan 2026 15:06:29 +0900
From: "Jesung Yang" <y.j3ms.n@...il.com>
To: "Tamir Duberstein" <tamird@...nel.org>, "Jesung Yang"
<y.j3ms.n@...il.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng"
<boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
<lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Danilo
Krummrich" <dakr@...nel.org>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
"Daniel Almeida" <daniel.almeida@...labora.com>, "Fiona Behrens"
<me@...enk.dev>
Subject: Re: [PATCH 0/4] scripts: generate_rust_analyzer.py: tidy and add
type hints
On Fri Jan 23, 2026 at 2:30 AM KST, Tamir Duberstein wrote:
> This series adds type annotations to generate_rust_analyzer.py. It is a
> subset of an earlier series[0] with formatting-only and drive-by patches
> removed (I sent some of these as separate single-patch series).
>
> The final commit leverages type hints to tidy the implementation. It
> could be done separately from this series, but serves as a nice
> demonstration.
>
> Link: https://lore.kernel.org/all/20250424-rust-analyzer-host-v6-0-40e67fe5c38a@gmail.com/ [0]
>
> Signed-off-by: Tamir Duberstein <tamird@...nel.org>
Great work, thanks! For the entire series,
Reviewed-by: Jesung Yang <y.j3ms.n@...il.com>
Tested-by: Jesung Yang <y.j3ms.n@...il.com>
Best regards,
Jesung
> ---
> Tamir Duberstein (4):
> scripts: generate_rust_analyzer.py: extract `{build,register}_crate`
> scripts: generate_rust_analyzer.py: drop `"is_proc_macro": false`
> scripts: generate_rust_analyzer.py: add type hints
> scripts: generate_rust_analyzer.py: identify crates explicitly
>
> scripts/generate_rust_analyzer.py | 256 ++++++++++++++++++++++++++++----------
> 1 file changed, 191 insertions(+), 65 deletions(-)
> ---
> base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
> change-id: 20260122-rust-analyzer-types-f90bda766749
>
> Best regards,
> --
> Tamir Duberstein <tamird@...nel.org>
Powered by blists - more mailing lists