linux-kernel - Re: [PATCH v6] watchdog/hardlockup: simplify perf event probe and remove per-cpu dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260128061350.1716608-1-realwujing@gmail.com>
Date: Wed, 28 Jan 2026 01:13:44 -0500
From: Qiliang Yuan <realwujing@...il.com>
To: dianders@...omium.org
Cc: akpm@...ux-foundation.org,
	lihuafei1@...wei.com,
	linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org,
	mingo@...nel.org,
	mm-commits@...r.kernel.org,
	realwujing@...il.com,
	song@...nel.org,
	sunshx@...natelecom.cn,
	thorsten.blum@...ux.dev,
	wangjinchao600@...il.com,
	yangyicong@...ilicon.com,
	yuanql9@...natelecom.cn,
	zhangjn11@...natelecom.cn
Subject: Re: [PATCH v6] watchdog/hardlockup: simplify perf event probe and remove per-cpu dependency

Hi Doug,

On Tue, Jan 27, 2026 at 8:08 PM Doug Anderson <dianders@...omium.org> wrote:
> One last note is that your Signed-off-by tags don't match. When I
> apply your patch, I see:
>
> Author:     Qiliang Yuan <realwujing@...il.com>
>
> ...but your Signed-off-by is your "@chinatelecom.cn" address. That's
> generally not okay. You need to do something to make those match.

Thank you for pointing this out. I've updated my git configuration and 
the patch to ensure the Signed-off-by matches the Author's Gmail address.

> Given our newest understanding, the cpu_hotplug_disable() isn't truly
> needed anymore, but I'm still good keeping it.

Since the probe is now fully stateless and no longer touches per-cpu 
variables, I've opted to remove the redundant cpu_hotplug_disable() in 
v7 to make the code cleaner, as you suggested it wasn't strictly necessary.

v7 Link: https://lore.kernel.org/all/20260128060833.1715622-1-realwujing@gmail.com/

Thanks again for your detailed review and guidance!

Best regards,
Qiliang