linux-kernel - Re: [PATCH] pinctrl: renesas: rzt2h: Fix device node leak in rzt2h_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLkmywtWQfZzRYNSqFGNDGp6_MWq2k7YH_aiNGo01cWpqA@mail.gmail.com>
Date: Wed, 28 Jan 2026 08:55:34 +0100
From: Linus Walleij <linusw@...nel.org>
To: Felix Gu <ustc.gu@...il.com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, 
	Thierry Bultel <thierry.bultel.yh@...renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, linux-renesas-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: renesas: rzt2h: Fix device node leak in rzt2h_gpio_register()

Hi Felix,

thanks for your patch!

On Mon, Jan 26, 2026 at 5:35 PM Felix Gu <ustc.gu@...il.com> wrote:

> +       of_node_put(of_args.np);
>         if (of_args.args[0] != 0 || of_args.args[1] != 0 ||
>             of_args.args[2] != pctrl->data->n_port_pins)
>                 return dev_err_probe(dev, -EINVAL,

To me it's a bit odd to dereference .np and then use other parts of
the args the next line but maybe that works.

Geert will decide on the patch.

Yours,
Linus Walleij