linux-kernel - Re: [PATCH] pinctrl: equilibrium: Fix device node reference leak in pinbank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jL=oy-GXDCvoFheYimvsJOtqX_2qHdugt4ZhVw6oOOcyJg@mail.gmail.com>
Date: Wed, 28 Jan 2026 08:56:57 +0100
From: Linus Walleij <linusw@...nel.org>
To: Felix Gu <ustc.gu@...il.com>
Cc: Rahul Tanwar <rahul.tanwar@...ux.intel.com>, 
	Andy Shevchenko <andriy.shevchenko@...el.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: equilibrium: Fix device node reference leak in pinbank_init()

On Mon, Jan 26, 2026 at 6:30 PM Felix Gu <ustc.gu@...il.com> wrote:

> When calling of_parse_phandle_with_fixed_args(), the caller is
> responsible to call of_node_put() to release the reference of device
> node.
>
> In pinbank_init(), the reference of the node obtained from the
> "gpio-ranges" property is never released, resulting in a reference
> count leak.
>
> Add the missing of_node_put() call to fix the leak.
>
> Fixes: 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> Signed-off-by: Felix Gu <ustc.gu@...il.com>

Patch applied!

Yours,
Linus Walleij