linux-kernel - Re: [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org>
Date: Wed, 28 Jan 2026 09:01:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Miaoqing Pan <miaoqing.pan@....qualcomm.com>, jjohnson@...nel.org,
 johannes@...solutions.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 jonas.gorski@...il.com
Subject: Re: [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware
 handling based on device compatible

On 27/01/2026 18:31, Jeff Johnson wrote:
> On 1/21/2026 1:50 AM, Miaoqing Pan wrote:
>> The 'firmware-name' property was introduced to allow end-users and
>> integrators to select use-case-specific firmware for the WCN6855.
>> But for M.2 WLAN chips, there is no suitable DTS node to specify
>> the 'firmware-name' property. In addition, assigning firmware for
>> the M.2 PCIe interface causes chips that do not use use-case-specific
>> firmware to fail. Therefore, abandoning the approach of specifying
>> firmware in DTS. As an alternative, propose a static lookup table
>> mapping device compatible to firmware names.
>>
>> ---
>> v2:
>> - Drops `firmware-name` from completely.
>> - Updates the commit message to clearly state that the property is
>>   obsolete and the change is ABI-breaking but safe for upstream.
>> v3:
>>  - Deprecate 'firmware-name' property instead of obsolete.
>>  - Keep the ABI backwards compatible.
>> v4:
>>  - Use of_machine_is_compatible() to simplify the code.
>>  - Add back Acked-by tag. 
>> ---
>>
>> Miaoqing Pan (2):
>>   wifi: ath11k: add usecase firmware handling based on device compatible
>>   dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name'
>>     property
>>
>>  .../net/wireless/qcom,ath11k-pci.yaml         |  1 +
>>  drivers/net/wireless/ath/ath11k/core.c        | 27 +++++++++++++++++++
>>  drivers/net/wireless/ath/ath11k/core.h        |  4 +++
>>  3 files changed, 32 insertions(+)
>>
>>
>> base-commit: d8e1f4a193101a72235416f189b01131a57e26e9
> 
> Krzysztof,
> Since you previously NAKed this series, can you confirm that your review
> comments have been addressed?


Binding looks fine, but I did not check the driver.

Best regards,
Krzysztof