[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <34c47190-d44c-47fc-b41a-04857054d287@linux.ibm.com>
Date: Wed, 28 Jan 2026 13:33:25 +0530
From: Shrikanth Hegde <sshegde@...ux.ibm.com>
To: Swapnil Sapkal <swapnil.sapkal@....com>
Cc: mark.rutland@....com, alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
adrian.hunter@...el.com, thomas.falcon@...el.com, ashelat@...hat.com,
yu.c.chen@...el.com, gautham.shenoy@....com, ravi.bangoria@....com,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
namhyung@...nel.org, irogers@...gle.com, james.clark@....com
Subject: Re: [PATCH v1 0/6] perf sched stats: Fixes and improvements
On 1/28/26 12:19 AM, Swapnil Sapkal wrote:
> These patches contain fixes and improvements related to perf sched stats
> code. The series includes:
>
> * Bug fixes
> - Add NULL check for cd_map in perf sched stats to prevent potential
> NULL pointer dereference
> - Fix NULL check in cpumask_to_cpulist() in perf util
>
> * Code quality improvements:
> - Replace hardcoded max cpus value with MAX_NR_CPUS constant in perf
> header
> - Define SEP_LEN macro to replace magic number in perf sched stats
> - Correct spelling of function name in perf sched stats
>
> * Documentation:
> - Fix various issues in the perf sched stats man page
>
> Swapnil Sapkal (6):
> perf header: Replace hardcoded max cpus by MAX_NR_CPUS
> perf util: Fix NULL check in cpumask_to_cpulist()
> perf sched stats: Add NULL check for cd_map
> perf sched stats: correct spelling of function name
> perf sched stats: Define macro for SEP_LEN
> perf sched stats: Fixes in man page
>
> tools/perf/Documentation/perf-sched.txt | 8 +++----
> tools/perf/builtin-sched.c | 30 +++++++++++++++----------
> tools/perf/util/header.c | 5 +++--
> tools/perf/util/util.c | 2 +-
> 4 files changed, 26 insertions(+), 19 deletions(-)
>
Other than the comment in Patch 1/6, rest looks good to me.
For the series:
Reviewed-by: Shrikanth Hegde <sshegde@...ux.ibm.com>
Powered by blists - more mailing lists