linux-kernel - Re: [PATCH 4/7] x86/microcode: Distinguish NMI control path on stop-machine callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikcm9mxz.ffs@tglx>
Date: Wed, 28 Jan 2026 09:11:04 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: "Chang S. Bae" <chang.seok.bae@...el.com>, linux-kernel@...r.kernel.org
Cc: x86@...nel.org, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, peterz@...radead.org, david.kaplan@....com,
 chang.seok.bae@...el.com
Subject: Re: [PATCH 4/7] x86/microcode: Distinguish NMI control path on
 stop-machine callback

On Sun, Jan 25 2026 at 01:42, Chang S. Bae wrote:
>  static int load_cpus_stopped(void *unused)
>  {
> -	if (microcode_ops->use_nmi) {
> -		/* Enable the NMI handler and raise NMI */
> -		this_cpu_write(ucode_ctrl.nmi_enabled, true);
> -		apic->send_IPI(smp_processor_id(), NMI_VECTOR);
> -	} else {
> -		/* Just invoke the handler directly */
> -		microcode_update_handler();
> -	}
> +	/* Enable the NMI handler and raise NMI */
> +	this_cpu_write(ucode_ctrl.nmi_enabled, true);
> +	apic->send_IPI(smp_processor_id(), NMI_VECTOR);
> +

With this change the function name is completely bogus.