linux-kernel - [PATCH v2] procfs: fix missing RCU protection when reading real_parent in do_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260128083007.3173016-1-alexjlzheng@tencent.com>
Date: Wed, 28 Jan 2026 16:30:07 +0800
From: alexjlzheng@...il.com
To: oleg@...hat.com,
	usamaarif642@...il.com,
	david@...nel.org,
	akpm@...ux-foundation.org,
	lorenzo.stoakes@...cle.com,
	mingo@...nel.org,
	alexjlzheng@...cent.com,
	ruippan@...cent.com,
	mjguzik@...il.com
Cc: linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: [PATCH v2] procfs: fix missing RCU protection when reading real_parent in do_task_stat()

From: Jinliang Zheng <alexjlzheng@...cent.com>

When reading /proc/[pid]/stat, do_task_stat() accesses task->real_parent
without proper RCU protection, which leads:

  cpu 0                               cpu 1
  -----                               -----
  do_task_stat
    var = task->real_parent
                                      release_task
                                        call_rcu(delayed_put_task_struct)
    task_tgid_nr_ns(var)
      rcu_read_lock   <--- Too late to protect task->real_parent!
      task_pid_ptr    <--- UAF!
      rcu_read_unlock

This patch use task_ppid_nr_ns() instead of task_tgid_nr_ns() to adds
proper RCU protection for accessing task->real_parent.

Fixes: 06fffb1267c9 ("do_task_stat: don't take rcu_read_lock()")
Signed-off-by: Jinliang Zheng <alexjlzheng@...cent.com>
---
changelog:

v2: - use task_ppid_nr_ns(), suggested by Oleg Nesterov
    - clear commit message

v1: https://lore.kernel.org/linux-fsdevel/20260127150450.2073236-1-alexjlzheng@tencent.com/
---
 fs/proc/array.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index 42932f88141a..5571177e0435 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -528,7 +528,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
 		}
 
 		sid = task_session_nr_ns(task, ns);
-		ppid = task_tgid_nr_ns(task->real_parent, ns);
+		ppid = task_ppid_nr_ns(task, ns);
 		pgid = task_pgrp_nr_ns(task, ns);
 
 		unlock_task_sighand(task, &flags);
-- 
2.49.0