linux-kernel - Re: [PATCH net-next v4 1/8] net: dsa: microchip: Add support for KSZ8463 global irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9cb204b-e079-4f5b-b670-dcce14101390@bootlin.com>
Date: Wed, 28 Jan 2026 10:22:46 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Woojung Huh <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com,
 Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>,
 Simon Horman <horms@...nel.org>, Pascal Eberhard <pascal.eberhard@...com>,
 Miquèl Raynal <miquel.raynal@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/8] net: dsa: microchip: Add support for
 KSZ8463 global irq

Hi Jakub,

On 1/28/26 4:03 AM, Jakub Kicinski wrote:
> On Tue, 27 Jan 2026 10:06:43 +0100 Bastien Curutchet (Schneider
> Electric) wrote:
>>   	/* Read interrupt status register */
>> -	ret = ksz_read8(dev, kirq->reg_status, &data);
>> +	ret = ksz_read16(dev, kirq->reg_status, &data);
> 
> AI code review points out that we're potentially over-reading here for
> !ksz_is_ksz8463(kirq->dev), I'm assuming the wider read is okay for all
> chips? Is this something that'll be obvious to all readers of this code
> or should we perhaps leave a relevant comment here? (assuming you need
> to respin, not sure its worth a respin by itself)

The loop below this read only iterates over the first kirq->nirqs bits, 
so I assume a wider read is fine. I wanted to avoid adding if 
(ksz_is_ksz8463()) branches as much as possible.

Indeed, a comment wouldn't hurt here; I'll add one if I need to respin.

Best regards,
Bastien