linux-kernel - Re: [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a820c04c224366e31ffbc6d7fe38068f8aab4137.camel@gmail.com>
Date: Wed, 28 Jan 2026 09:29:47 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: Chen Ni <nichen@...as.ac.cn>, haibo.chen@....com, jic23@...nel.org, 
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org
Cc: linux-iio@...r.kernel.org, imx@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: vf610: Add missing check for
 device_property_read_u32_array

On Wed, 2026-01-28 at 12:27 +0800, Chen Ni wrote:
> Add check for the return value of device_property_read_u32_array() and
> return the error if it fails in order to catch the error.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/iio/adc/vf610_adc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index d7182ed0d2a7..d53723ccc5b2 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -871,7 +871,10 @@ static int vf610_adc_probe(struct platform_device *pdev)
>  
>  	info->vref_uv = regulator_get_voltage(info->vref);
>  
> -	device_property_read_u32_array(dev, "fsl,adck-max-frequency", info->max_adck_rate, 3);
> +	ret = device_property_read_u32_array(dev, "fsl,adck-max-frequency",
> +					     info->max_adck_rate, 3);
> +	if (ret)
> +		return ret;

As Andy pointed out, this is changing behavior so it needs to be properly justified. Also since we
are here, maybe use ARRAY_SIZE(info->max_adck_rate).

- Nuno Sá

>  
>  	info->adc_feature.default_sample_time = DEFAULT_SAMPLE_TIME;
>  	device_property_read_u32(dev, "min-sample-time", &info->adc_feature.default_sample_time);