linux-kernel - Re: [PATCH] iio: sca3000: Fix a resource leak in sca3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXnbcNYWaf2u9I4u@smile.fi.intel.com>
Date: Wed, 28 Jan 2026 11:48:32 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Gustavo Bastos <gustavobastos@....br>,
	Andrew Ijano <andrew.ijano@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, dan.carpenter@...aro.org,
	kernel-janitors@...r.kernel.org, error27@...il.com
Subject: Re: [PATCH] iio: sca3000: Fix a resource leak in sca3000_probe()

On Tue, Jan 27, 2026 at 10:49:49PM -0800, Harshit Mogalapalli wrote:
> spi->irq from request_threaded_irq() not released when
> iio_device_register() fails. Add an return value check and jump to a
> common error handler when iio_device_register() fails.

LGTM, but I would rather converting this to use managed resources.

So, if Jonathan wants to take this first,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

-- 
With Best Regards,
Andy Shevchenko