linux-kernel - Re: [PATCH v2] staging: sm750fb: replace magic number with jiffies timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012844-gazing-shawl-1662@gregkh>
Date: Wed, 28 Jan 2026 11:31:03 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: MADHU ANAND <madhuananda18@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: replace magic number with jiffies
 timeout

On Wed, Jan 28, 2026 at 10:18:07AM +0000, MADHU ANAND wrote:
> My apologies for the private reply and the top-posting. I am resending my
> responses to the list now and will ensure correct formatting going forward.
> 
> You're absolutely right. I over-engineered the implementation and added
> redundant comments that shouldn't be there.
> 
> To address your points:
> 
>    1.

Sorry, I don't have much context here, you seem to have removed my
responses and the original patch entirely :(

Remember, some of us get over 1000 emails a day and context in an email
matters to know what is going on.

>    I used 1 second (HZ) as a safe upper bound, but since I don't have the
>    hardware to verify the original loop's speed, this was an assumption.

If you are changing timing loops, testing on the real hardware is
essencial.  Please don't do any sort of logic changes like this without
being able to do so.

thanks,

greg k-h