linux-kernel - Re: [PATCH net-next v3 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176959754960.624625.3292309980701778789.robh@kernel.org>
Date: Wed, 28 Jan 2026 04:52:29 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-riscv@...ts.infradead.org, Albert Ou <aou@...s.berkeley.edu>, 
 Andrew Lunn <andrew+netdev@...n.ch>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Yao Zi <ziyao@...root.org>, 
 Longbin Li <looong.bin@...il.com>, linux-stm32@...md-mailman.stormreply.com, 
 Choong Yong Liang <yong.liang.choong@...ux.intel.com>, 
 Yixun Lan <dlan@...too.org>, Quentin Schulz <quentin.schulz@...rry.de>, 
 Jakub Kicinski <kuba@...nel.org>, devicetree@...r.kernel.org, 
 Paolo Abeni <pabeni@...hat.com>, Conor Dooley <conor+dt@...nel.org>, 
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
 Paul Walmsley <pjw@...nel.org>, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 Giuseppe Cavallaro <peppe.cavallaro@...com>, 
 Boon Khai Ng <boon.khai.ng@...era.com>, 
 Yanteng Si <siyanteng@...oftware.com.cn>, spacemit@...ts.linux.dev, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 Palmer Dabbelt <palmer@...belt.com>, 
 Richard Cochran <richardcochran@...il.com>, 
 Shangjuan Wei <weishangjuan@...incomputing.com>, 
 Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, 
 Chen-Yu Tsai <wens@...nel.org>, 
 Maxime Chevallier <maxime.chevallier@...tlin.com>, 
 "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, 
 Alexandre Ghiti <alex@...ti.fr>, Jose Abreu <joabreu@...opsys.com>, 
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v3 1/3] dt-bindings: net: Add support for
 Spacemit K3 dwmac

On Wed, 28 Jan 2026 15:29:27 +0800, Inochi Amaoto wrote:
> The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare
> MAC (version 5.40a) with some extra clock.
> 
> Add necessary compatible string for this device.
> 
> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   |   2 +
>  .../bindings/net/spacemit,k3-dwmac.yaml       | 103 ++++++++++++++++++
>  2 files changed, 105 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/spacemit,k3-dwmac.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@...80000 (spacemit,k3-dwmac): compatible: ['spacemit,k3-dwmac', 'snps,dwmac-5.40a'] does not contain items matching the given schema
	from schema $id: http://devicetree.org/schemas/net/snps,dwmac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@...80000 (spacemit,k3-dwmac): compatible: ['spacemit,k3-dwmac', 'snps,dwmac-5.40a'] does not contain items matching the given schema
	from schema $id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/spacemit,k3-dwmac.example.dtb: ethernet@...80000 (spacemit,k3-dwmac): Unevaluated properties are not allowed ('phy-handle', 'phy-mode' were unexpected)
	from schema $id: http://devicetree.org/schemas/net/spacemit,k3-dwmac.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260128072931.875041-2-inochiama@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.