linux-kernel - [tip: x86/platform] x86/hyperv: Fix smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <176959812223.510.4055929851272785854.tip-bot2@tip-bot2>
Date: Wed, 28 Jan 2026 11:02:02 -0000
From: "tip-bot2 for Ingo Molnar" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Mukesh Rathor <mrathor@...ux.microsoft.com>, Wei Liu <wei.liu@...nel.org>,
 linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>, x86@...nel.org
Subject:
 [tip: x86/platform] x86/hyperv: Fix smp_ops build failure on UP kernels

The following commit has been merged into the x86/platform branch of tip:

Commit-ID:     ac059ae422d7d05ed9d62970a30fa3b95870b967
Gitweb:        https://git.kernel.org/tip/ac059ae422d7d05ed9d62970a30fa3b95870b967
Author:        Ingo Molnar <mingo@...nel.org>
AuthorDate:    Wed, 28 Jan 2026 11:35:20 +01:00
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Wed, 28 Jan 2026 11:54:04 +01:00

x86/hyperv: Fix smp_ops build failure on UP kernels

CI testing found this build failure:

  arch/x86/hyperv/hv_crash.c:631:9: error: ‘smp_ops’ undeclared (first use in this function)

And I bisected it back to the initial commit that enabled this feature:

  77c860d2dbb72d1f3c6a2e882a07d19eca399db5 is the first bad commit
  commit 77c860d2dbb72d1f3c6a2e882a07d19eca399db5 (HEAD)
  Author: Mukesh Rathor <mrathor@...ux.microsoft.com>
  Date:   Mon Oct 6 15:42:08 2025 -0700

  x86/hyperv: Enable build of hypervisor crashdump collection files

Hyperv should probably be limited to SMP kernels, as nobody
appears to be testing it on UP kernels.

Until then, fix the smp_ops assumption. Build tested only.

Fixes: 77c860d2dbb72 ("x86/hyperv: Enable build of hypervisor crashdump collection files")
Cc: Mukesh Rathor <mrathor@...ux.microsoft.com>
Cc: Wei Liu <wei.liu@...nel.org>
Cc: linux-kernel@...r.kernel.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/hyperv/hv_crash.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/hyperv/hv_crash.c b/arch/x86/hyperv/hv_crash.c
index c0e2292..a78e4fe 100644
--- a/arch/x86/hyperv/hv_crash.c
+++ b/arch/x86/hyperv/hv_crash.c
@@ -628,7 +628,9 @@ void hv_root_crash_init(void)
 	if (rc)
 		goto err_out;
 
+#ifdef CONFIG_SMP
 	smp_ops.crash_stop_other_cpus = hv_crash_stop_other_cpus;
+#endif
 
 	crash_kexec_post_notifiers = true;
 	hv_crash_enabled = true;