linux-kernel - Re: [PATCH v3 1/2] genirq/matrix: Clarify CPU selection logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cy2u9els.ffs@tglx>
Date: Wed, 28 Jan 2026 12:11:11 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: Zhan Xusheng <zhanxusheng1024@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-irq@...r.kernel.org, Zhan Xusheng
 <zhanxusheng@...omi.com>
Subject: Re: [PATCH v3 1/2] genirq/matrix: Clarify CPU selection logic

On Wed, Jan 28 2026 at 11:14, Zhan Xusheng wrote:
> The CPU selection loops in matrix_find_best_cpu() and
> matrix_find_best_cpu_managed() mix the online check with the
> comparison that determines whether a CPU becomes the current
> best candidate.

What's wrong about that?

> Restructure the loops to filter out offline CPUs first and then
> perform the comparison separately. This makes the selection
> criteria easier to read and reason about.

It's just different and not any better. We are not reshuffling perfectly
correct code just to accomodate with personal taste of someone.

Thanks,

        tglx