linux-kernel - Re: [PATCH] selftests: runner: Avoid spurious warning about missing failures file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DG06J6S40UW7.15VFU5DA8YJIY@google.com>
Date: Wed, 28 Jan 2026 11:18:35 +0000
From: Brendan Jackman <jackmanb@...gle.com>
To: "Thomas Weißschuh" <thomas.weissschuh@...utronix.de>, Shuah Khan <shuah@...nel.org>, 
	Brendan Jackman <jackmanb@...gle.com>
Cc: Shuah Khan <skhan@...uxfoundation.org>, <linux-kselftest@...r.kernel.org>, 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests: runner: Avoid spurious warning about missing
 failures file

On Wed Jan 28, 2026 at 9:05 AM UTC, Thomas Weißschuh wrote:
> When runner.sh is *not* executed via run_kselftest.sh, 

Hm, what's the usecase for that? runner.sh is a "library", right? So in
my mind there's basically an undocumented contract that you need to set
this variable before you call the relevant functions.

The fix below opens the door to bugs where we fail to report test
failures which would be... a shame!

> the variable
> $kselftest_failures_file does not exist. This triggers a harmless but
> annyoing warning from runner.sh if a test fails:
>
> tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
>
> Silence the spurious warning.
>
> Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if tests fail")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

Having said that, it's not a big deal, the risk of those bugs is not
that high and we'd probably notice them before too long. Assuming you
have a usecase where just setting the variable to /dev/null yourself is
a pain, this LGTM.

Reviewed-By: Brendan Jackman <jackmanb@...gle.com>