linux-kernel - Re: [PATCH net 3/3] net/mlx5e: Account for netdev stats in ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5df3b60-246a-4030-9c9a-0a35cd1ca924@nvidia.com>
Date: Wed, 28 Jan 2026 13:28:16 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Saeed Mahameed <saeedm@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, Mark Bloch <mbloch@...dia.com>,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net 3/3] net/mlx5e: Account for netdev stats in
 ndo_get_stats64

On 28/01/2026 5:52, Jakub Kicinski wrote:
> On Mon, 26 Jan 2026 09:14:55 +0200 Tariq Toukan wrote:
>> The driver's ndo_get_stats64 callback is only reporting mlx5 counters,
>> without accounting for the netdev stats, causing errors from the network
>> stack to be invisible in statistics.
> 
> I cooked up a patch to fix this generically in the core... but I can't
> actually find any "errors from the network stack" that are accounted
> to dev->stats. Could you be more specific about the issues you were
> seeing?

My original motivation was identifying packet drops in the GRE stack,
specifically in gre_rcv() after an error in gre_parse_header() (in my
case, due to a checksum error).
Currently, these packets are silently dropped. I have additional patches
that increment the rx_dropped/rx_crc_errors counters in that path, which
exposed the issue, but they haven't been submitted yet.

However, you are right that it's hard to find existing dev->stats
increments, the use case this currently fixes is an error in
__bpf_redirect_neigh_v4()/__bpf_redirect_neigh_v6().