linux-kernel - Re: [PATCH v3] bus: fsl-mc: fix an error handling in fsl_mc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2nwskmo3gta3fkharhzeg5fj66pymj5az7wiv7wfa4gfa3mrid@iswqizf6qhrg>
Date: Wed, 28 Jan 2026 14:15:02 +0200
From: Ioana Ciornei <ioana.ciornei@....com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: stuart.yoder@...escale.com, agraf@...e.de, German.Rivera@...escale.com, 
	gregkh@...uxfoundation.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>, 
	Su Hui <suhui@...china.com>, Christophe Leroy <chleroy@...nel.org>
Subject: Re: [PATCH v3] bus: fsl-mc: fix an error handling in
 fsl_mc_device_add()

On Sat, Jan 24, 2026 at 06:20:54PM +0800, Haoxiang Li wrote:
> In fsl_mc_device_add(), device_initialize() is called first.
> put_device() should be called to drop the reference if error
> occurs. And other resources would be released via put_device
> -> fsl_mc_device_release. So remove redundant kfree() in
> error handling path.
> 
> Fixes: bbf9d17d9875 ("staging: fsl-mc: Freescale Management Complex (fsl-mc) bus driver")
> Cc: stable@...r.kernel.org
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/
> Signed-off-by: Su Hui <suhui@...china.com>
> Suggested-by: Christophe Leroy (CS GROUP) <chleroy@...nel.org>
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

Reviewed-by: Ioana Ciornei <ioana.ciornei@....com>