linux-kernel - Re: [PATCH v1] platform/x86: classmate-laptop: Add missing NULL pointer checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176960506373.3435.18235456408554056722.b4-ty@linux.intel.com>
Date: Wed, 28 Jan 2026 14:57:43 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Hans de Goede <hansg@...nel.org>, 
 "Rafael J. Wysocki" <rafael@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, 
 Linux ACPI <linux-acpi@...r.kernel.org>, 
 platform-driver-x86@...r.kernel.org, 
 Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
Subject: Re: [PATCH v1] platform/x86: classmate-laptop: Add missing NULL
 pointer checks

On Mon, 26 Jan 2026 21:02:40 +0100, Rafael J. Wysocki wrote:

> In a few places in the Classmate laptop driver, code using the accel
> object may run before that object's address is stored in the driver
> data of the input device using it.
> 
> For example, cmpc_accel_sensitivity_store_v4() is the "show" method
> of cmpc_accel_sensitivity_attr_v4 which is added in cmpc_accel_add_v4(),
> before calling dev_set_drvdata() for inputdev->dev.  If the sysfs
> attribute is accessed prematurely, the dev_get_drvdata(&inputdev->dev)
> call in in cmpc_accel_sensitivity_store_v4() returns NULL which
> leads to a NULL pointer dereference going forward.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: classmate-laptop: Add missing NULL pointer checks
      commit: fe747d7112283f47169e9c16e751179a9b38611e

--
 i.