linux-kernel - Re: [PATCH v2 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALs4sv13fcPPQfSc0L_jUJ3gmwdkhBqEMjvn=af2ettFQNin7g@mail.gmail.com>
Date: Thu, 29 Jan 2026 19:26:30 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Leon Romanovsky <leon@...nel.org>
Cc: jgg@...pe.ca, michael.chan@...adcom.com, linux-kernel@...r.kernel.org, 
	dave.jiang@...el.com, saeedm@...dia.com, Jonathan.Cameron@...wei.com, 
	gospo@...adcom.com, selvin.xavier@...adcom.com, 
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH v2 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl

On Thu, Jan 29, 2026 at 7:06 PM Leon Romanovsky <leon@...nel.org> wrote:
>
> On Sun, Jan 25, 2026 at 09:37:08PM -0800, Pavan Chebbi wrote:
> > Create an additional auxiliary device to support fwctl.
> > The next patch will create bnxt_fwctl and bind to this
> > device.
> >
> > Reviewed-by: Andy Gospodarek <gospo@...adcom.com>
> > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > ---
> >  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++--
> >  include/linux/bnxt/ulp.h                      |  1 +
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> > index 4cdfc9641639..13159c0515bb 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> > @@ -62,6 +62,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx)
> >
> >  static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{
> >       .name           = "rdma",
> > +}, {
> > +     .name           = "fwctl",
> >  }};
>
> I would expect the name to be part of auxiliary_driver initialization
> and not dynamically added.

No, this is more like struct mlx5_adev_device.

>
>   5113 static struct auxiliary_driver mlx5r_driver = {
>   5114         .name = "rdma",
>   5115         .probe = mlx5r_probe,
>   5116         .remove = mlx5r_remove,
>   5117         .id_table = mlx5r_id_table,
>   5118 };
>
> Thanks

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)