linux-kernel - Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1c51aa9-19e5-4335-9b70-bbcc4d6def85@molgen.mpg.de>
Date: Thu, 29 Jan 2026 17:18:00 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Vivek Sahu <vivek.sahu@....qualcomm.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Balakrishna Godavarthi <quic_bgodavar@...cinc.com>,
 Rocky Liao <quic_rjliao@...cinc.com>,
 Mohammed Sameer Mulla <quic_mohamull@...cinc.com>,
 Harish Bandi <quic_hbandi@...cinc.com>, linux-bluetooth@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string
 "qcom,qcc2072-bt" to yaml file.

Dear Vivek,


Am 29.01.26 um 06:59 schrieb Vivek Sahu:
> 
> On 1/20/2026 3:38 PM, Vivek Sahu wrote:
>>> ________________________________
>>> From: Paul Menzel <pmenzel@...gen.mpg.de>
>>> Sent: 17 December 2025 19:44
>>> To: Vivek Sahu <vivesahu@....qualcomm.com>
>>> Cc: Marcel Holtmann <marcel@...tmann.org>; Luiz Augusto von Dentz 
>>> <luiz.dentz@...il.com>; Rob Herring <robh@...nel.org>; Krzysztof 
>>> Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; 
>>> Bartosz Golaszewski <brgl@...ev.pl>; Balakrishna Godavarthi (QUIC) 
>>> <quic_bgodavar@...cinc.com>; Rocky Liao (QUIC) 
>>> <quic_rjliao@...cinc.com>; Mohammed Sameer Mulla (QUIC) 
>>> <quic_mohamull@...cinc.com>; Harish Bandi (QUIC) 
>>> <quic_hbandi@...cinc.com>; linux-bluetooth@...r.kernel.org <linux- 
>>> bluetooth@...r.kernel.org>; devicetree@...r.kernel.org 
>>> <devicetree@...r.kernel.org>; linux-kernel@...r.kernel.org <linux- 
>>> kernel@...r.kernel.org>; linux-arm-msm@...r.kernel.org <linux-arm- 
>>> msm@...r.kernel.org>
>>> Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT 
>>> compatible string "qcom,qcc2072-bt" to yaml file.
>>>
>>> WARNING: This email originated from outside of Qualcomm. Please be 
>>> wary of any links or attachments, and do not enable macros.
>>>
>>> Dear Vivek,
>>>
>>>
>>> Thank you for your patch. The formatting is off, and the summary/title
>>> (subject) has two statements – look yourself in the archive [1]. Also
>>> the prefix seems wrong.
>>>
>>> Am 17.12.25 um 12:28 schrieb Vivek Kumar Sahu:
>>>> Signed-off-by: Vivek Kumar Sahu <vivesahu@....qualcomm.com>
>>> Please elaborate by giving more context, why it is compatible, and I’d
>>> like to see how you tested this.
>>
>> The compatible string "qcom,qcc2072-bt" is defined in target dtsi file 
>> and it was tested on the hardware. The corresponding target specific 
>> dtsi file is currently merged in downstream.
> Please let me know if above statement gets you the answer of your question.
>>
>>>
>>>> ---
>>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> index 6353a336f382..197248d6f7b8 100644
>>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> @@ -28,6 +28,7 @@ properties:
>>>>          - qcom,wcn6750-bt
>>>>          - qcom,wcn6855-bt
>>>>          - qcom,wcn7850-bt
>>>> +      - qcom,qcc2072-bt
>>> Lacking more lines, I am not certain, but I maybe this should be sorted.
>> I'll address it in next patch of this commit.
> I just checked that "qca_btsoc_type" enum contains all the soc type 
> which need to be enabled for BT enablement on the target device.
> There are few places where logic of framing packets transferring
> between SoC  and Host depends on the which generation of the chip it
> is, refer api "qca_read_soc_version".>
> Do you still suggest to sort it here ?

Yes, I’d prefer it sorted to easily find entries in the list. I suggest 
to create a separate commit to sort qcom,qca6390-bt correctly, and then 
your patch on top with qcc ordered after qca.

>>>>      enable-gpios:
>>>>        maxItems: 1


Kind regards,

Paul


>>> [1]: https://lore.kernel.org/all/20251217112850.520572-1-vivesahu@qti.qualcomm.com/