linux-kernel - Re: [PATCH 2/3] iio: accel: adxl380: remove unused odr field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260129162446.39e7adf4@jic23-huawei>
Date: Thu, 29 Jan 2026 16:24:46 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Michael Hennerich <michael.hennerich@...log.com>, Lars-Peter Clausen
 <lars@...afoo.de>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Ramona Gradinariu <ramona.gradinariu@...log.com>, Andrew Ijano
 <andrew.ijano@...il.com>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] iio: accel: adxl380: remove unused odr field

On Thu, 29 Jan 2026 16:11:58 +0200
Antoniu Miclaus <antoniu.miclaus@...log.com> wrote:

> Remove unused odr field from adxl380_state struct.
> The field is declared but never accessed in the driver.
It is used in my tree...

I blindly applied this on assumption a build test was quicker than
checking if you were right :)

drivers/iio/accel/adxl380.c:271:8: error: no member named 'odr' in 'struct adxl380_state'
  271 |                         st->odr = ADXL380_ODR_VLP;
      |                         ~~  ^
drivers/iio/accel/adxl380.c:273:11: error: no member named 'odr' in 'struct adxl380_state'
  273 |                 if (st->odr == ADXL380_ODR_VLP)
      |                     ~~  ^
drivers/iio/accel/adxl380.c:440:42: error: no member named 'odr' in 'struct adxl380_state'
  440 |         *odr = st->chip_info->samp_freq_tbl[st->odr];
      |                                             ~~  ^
drivers/iio/accel/adxl380.c:518:6: error: no member named 'odr' in 'struct adxl380_state'
  518 |         st->odr = odr;
      |         ~~  ^
drivers/iio/accel/adxl380.c:1967:6: error: no member named 'odr' in 'struct adxl380_state'
 1967 |         st->odr = ADXL380_ODR_DSM;
      |         ~~  ^
5 errors generated.


> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
>  drivers/iio/accel/adxl380.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c
> index aef5109c1ddd..4c584f6ec902 100644
> --- a/drivers/iio/accel/adxl380.c
> +++ b/drivers/iio/accel/adxl380.c
> @@ -206,7 +206,6 @@ struct adxl380_state {
>  	struct mutex lock;
>  	enum adxl380_axis tap_axis_en;
>  	u8 range;
> -	u8 odr;
>  	u8 fifo_set_size;
>  	u8 transf_buf[3];
>  	u16 watermark;