linux-kernel - Re: [PATCH 3/3] iio: accel: sca3000: remove unused last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260129162602.694ce7e8@jic23-huawei>
Date: Thu, 29 Jan 2026 16:26:02 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Ramona Gradinariu <ramona.gradinariu@...log.com>, Andrew Ijano
 <andrew.ijano@...il.com>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] iio: accel: sca3000: remove unused last_timestamp
 field

On Thu, 29 Jan 2026 16:11:59 +0200
Antoniu Miclaus <antoniu.miclaus@...log.com> wrote:

> Remove unused last_timestamp field from sca3000_state
> struct. The field is declared but never accessed in the
> driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
Also fine so applied.

Thanks for tidying these up.

Jonathan

> ---
>  drivers/iio/accel/sca3000.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index bfa8a3f5a92f..950b4c672484 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -153,7 +153,6 @@
>   * struct sca3000_state - device instance state information
>   * @us:			the associated spi device
>   * @info:			chip variant information
> - * @last_timestamp:		the timestamp of the last event
>   * @mo_det_use_count:		reference counter for the motion detection unit
>   * @lock:			lock used to protect elements of sca3000_state
>   *				and the underlying device state.
> @@ -163,7 +162,6 @@
>  struct sca3000_state {
>  	struct spi_device		*us;
>  	const struct sca3000_chip_info	*info;
> -	s64				last_timestamp;
>  	int				mo_det_use_count;
>  	struct mutex			lock;
>  	/* Can these share a cacheline ? */