linux-kernel - Re: [PATCH] drm/panel-edp: Add CMN N116BCL-EAK-c2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=V2HzOYcOgeY94h+Pk33=niJrQzzZF0hLE+VH8Jacbfvw@mail.gmail.com>
Date: Thu, 29 Jan 2026 08:59:36 -0800
From: Doug Anderson <dianders@...omium.org>
To: Cong Yang <yangcong5@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, jesszhan0024@...il.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, treapking@...omium.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel-edp: Add CMN N116BCL-EAK-c2

Hi,

On Wed, Jan 28, 2026 at 7:30 PM Cong Yang
<yangcong5@...qin.corp-partner.google.com> wrote:
>
> Add support for the CMN N116BCL-EAK-c2, pleace the EDID here for
> subsequent reference.
>
> edid-decode (hex):
>
> 00 ff ff ff ff ff ff 00 0d ae 7a 11 00 00 00 00
> 08 22 01 04 95 1a 0e 78 03 46 a5 9c 5b 53 8b 24
> 1d 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 e6 1e 56 e2 50 00 3c 30 30 20
> a6 00 00 90 10 00 00 1a 00 00 00 fd 00 28 3c 32
> 32 08 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 4d 4e 0a 20 20 20 20 20 20 20 20 20 00 00 00 fe
> 00 4e 31 31 36 42 43 4c 2d 45 41 4b 0a 20 01 80
>
> 70 20 79 02 00 25 01 09 fc 34 01 fc 34 01 28 3c
> 80 81 00 10 72 1a 00 00 03 01 28 3c 00 00 00 00
> 00 00 3c 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 2f 90
>
> Signed-off-by: Cong Yang <yangcong5@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 108569490ed5..54c73bba1c14 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -2014,6 +2014,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('C', 'M', 'N', 0x1160, &delay_200_500_e80_d50, "N116BCJ-EAK"),
>         EDP_PANEL_ENTRY('C', 'M', 'N', 0x1161, &delay_200_500_e80, "N116BCP-EA2"),
>         EDP_PANEL_ENTRY('C', 'M', 'N', 0x1163, &delay_200_500_e80_d50, "N116BCJ-EAK"),
> +       EDP_PANEL_ENTRY('C', 'M', 'N', 0x117a, &delay_200_500_e80_d50, "N116BCL-EAK-c2"),

It's probably better to change the string to be just "N116BCL-EAK".
Even though there's already another "N116BCL-EAK" in the list, that's
OK. Why do I suggest that? The EDID itself has:

ASCII string: CMN
ASCII string: N116BCL-EAK

...and when the EDID has the ID string in it then it's best to match
that string exactly. That would help us if a vendor ever accidentally
re-used the same ID. See Hsin-Yi's patch 6e3fdedcf0bc ("drm/edid: Add
a function to match EDID with identity").

It's still a good idea to call the panel "N116BCL-EAK-c2" in the
commit message, though.


-Doug