linux-kernel - Re: [PATCH] iio: gyro: itg3200: Fix unchecked return value in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260129170744.48f0ce06@jic23-huawei>
Date: Thu, 29 Jan 2026 17:07:44 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Petre Rodan <petre.rodan@...dimension.ro>,
 Manuel Stahl <manuel.stahl@....fraunhofer.de>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: gyro: itg3200: Fix unchecked return value in
 read_raw

On Thu, 29 Jan 2026 17:53:22 +0200
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Thu, Jan 29, 2026 at 05:01:45PM +0200, Antoniu Miclaus wrote:
> > The return value from itg3200_read_reg_s16() is stored in ret but
> > never checked. The function unconditionally returns IIO_VAL_INT,
> > ignoring potential I2C read failures. This causes garbage data to
> > be returned to userspace when the read fails, with no error reported.  
> 
> > Add proper error checking to propagate the failure to callers.  
> 
> Yeah, but when it's not a series do not use --thread!
> (P.S. do not resend, it's for the future now)
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> 
Applied this patch to the togreg branch of iio.git (given nearness
of merge window) and marked for stable.