linux-kernel - Re: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with proper errno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <541a60a1-2373-4624-9320-c9b904a7af10@gmail.com>
Date: Thu, 29 Jan 2026 18:26:27 +0100
From: Omer El Idrissi <omer.e.idrissi@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with
 proper errno

Thanks for the explanation. I'll drop this change and revisit it once 
i'm more familiar with the driver

On 1/29/26 8:27 AM, Dan Carpenter wrote:
> On Wed, Jan 28, 2026 at 06:21:43PM +0100, Omer El Idrissi wrote:
>> Changes since v1:
>> - Removed leftover comment accidentally left in previous version
>> - No functional changes
>>
>> Signed-off-by: Omer El Idrissi <omer.e.idrissi@...il.com>
> No commit message.
>
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>
> Why is do you change -2 to both -EBUSY and -ENOBUFS?  In the original
> code, the -1 and -2 return meant something custom and they weren't
> kernel error codes:
>
>   * Return:
>   *0     Success
>   *-1    Hardware resource(TX FIFO) not ready
>   *-2    Software resource(xmitbuf) not ready
>
> Now the documentation makes no sense.
>
> regards,
> dan carpenter
>