linux-kernel - Re: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <700e4e67-a2ed-4b37-a00b-303bbc5ee6cd@sirena.org.uk>
Date: Thu, 29 Jan 2026 17:27:58 +0000
From: Mark Brown <broonie@...nel.org>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Vincenzo Frascino <vincenzo.frascino@....com>,
	Liam Girdwood <lgirdwood@...il.com>, linux-sound@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Michal Simek <michal.simek@....com>, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 2/2] ASoC: xilinx: xlnx_i2s: Discover parameters from
 registers

On Thu, Jan 29, 2026 at 12:23:15PM -0500, Sean Anderson wrote:

> -	ret = of_property_read_u32(node, "xlnx,num-channels", &drv_data->channels);

> -	ret = of_property_read_u32(node, "xlnx,dwidth", &drv_data->data_width);

Given that the properties already exist it seems wise to continue to
parse them if available and prefer them over what we read from the
hardware, it would not shock me to discover that hardware exists where
the registers are inaccurate or need overriding due to bugs.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)