linux-kernel - Re: [PATCH] iio: sca3000: Fix a resource leak in sca3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129182424.2c0b1cfa@jic23-huawei>
Date: Thu, 29 Jan 2026 18:24:24 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Gustavo Bastos <gustavobastos@....br>, Andrew
 Ijano <andrew.ijano@...il.com>, Lars-Peter Clausen <lars@...afoo.de>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
 error27@...il.com
Subject: Re: [PATCH] iio: sca3000: Fix a resource leak in sca3000_probe()

On Wed, 28 Jan 2026 20:15:06 +0530
Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com> wrote:

> Hi Andy,
> 
> On 28/01/26 15:18, Andy Shevchenko wrote:
> > On Tue, Jan 27, 2026 at 10:49:49PM -0800, Harshit Mogalapalli wrote:  
> >> spi->irq from request_threaded_irq() not released when
> >> iio_device_register() fails. Add an return value check and jump to a
> >> common error handler when iio_device_register() fails.  
> > 
> > LGTM, but I would rather converting this to use managed resources.
> >   
> 
> Thanks for the review.
> 
> I’ll follow up with a separate patch that converts it to devm-based
> resource handling. Maybe that helps in a way to keep the fix and
> refactor separate ?
> 
Yes.

> > So, if Jonathan wants to take this first,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> >  
Applied.

Not that often we get changes for this one. It was one of the
earliest IIO drivers. Anyhow, nothing wrong with modernising it
if you want to work on it!

Thanks,

Jonathan

> 
> Thanks!
> 
> Regards,
> Harshit
> 
>