linux-kernel - Re: [PATCH v2 3/6] iio: amplifiers: ad8366: refactor device resource management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129184025.4abd4fe0@jic23-huawei>
Date: Thu, 29 Jan 2026 18:40:25 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Rodrigo Alencar <455.rodrigo.alencar@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>,
 rodrigo.alencar@...log.com, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org, Michael Hennerich
 <Michael.Hennerich@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, David
 Lechner <dlechner@...libre.com>, Andy Shevchenko <andy@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 3/6] iio: amplifiers: ad8366: refactor device
 resource management

On Wed, 28 Jan 2026 09:31:10 +0000
Rodrigo Alencar <455.rodrigo.alencar@...il.com> wrote:

> On 26/01/27 11:12PM, Andy Shevchenko wrote:
> > On Mon, Jan 26, 2026 at 01:51:04PM +0000, Rodrigo Alencar via B4 Relay wrote:
> >   
> > > Adhere modern device resource management with the following:
> > > - Voltage regulator managed and enabled internally;
> > > - Proper mutex lifecycle with devm_mutex_init(), replacing mutex_init();
> > > - IIO device registration handled with devm_iio_device_register();
> > > - removal of goto's from the probe function;
> > > - ad8366_remove() removed as it is not needed anymore;
> > > 
> > > Also, dev_err_probe() is used to report probe errors with created local
> > > device pointer.  
> > 
> > And also it uses the temporary dev variable in the cases that are not covered
> > by the above.
> > 
> > So, three changes in one patch...  
> 
> I can split. Using proper devm functions allowed me to drop goto's and
> ad8366_remove(). Dropping the goto's allowed for the usage of
> dev_err_probe().

As general rule I prefer one patch one change, though just occasionally
I'll take the expedient view if a series is otherwise ready to merge
and one change is really really small.

J
> 
> I could place the temporary dev variable in a separate patch. 
> 
> > 
> > Dunno if Jonathan is okay with this. I would rather split it.
> > Code wise LGTM.  
> 
> Yeah I can now see it coming. Thanks for the review.
>