linux-kernel - Re: [PATCH v1 1/1] i2c: designware: Remove dead code in AMD ISP case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd3f15e8-f602-4833-9101-f1899add18c5@amd.com>
Date: Thu, 29 Jan 2026 14:03:22 -0500
From: "Nirujogi, Pratap" <pnirujog@....com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Andi Shyti <andi.shyti@...nel.org>, Pratap Nirujogi
 <pratap.nirujogi@....com>, linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Bin Du <bin.du@....com>
Subject: Re: [PATCH v1 1/1] i2c: designware: Remove dead code in AMD ISP case


On 1/29/2026 5:34 AM, Andy Shevchenko wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> The I²C bus shared with P-Unit is Intel only thing as far as I know.
> The AMD ISP driver has no relationship with P-Unit. Remove dead code
> that seems copied without much thinking.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

Thanks Andy.

Reviewed-by: Pratap Nirujogi <pratap.nirujogi@....com>

>   drivers/i2c/busses/i2c-designware-amdisp.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdisp.c b/drivers/i2c/busses/i2c-designware-amdisp.c
> index ec9259dd2a4f..c48728ad9f6f 100644
> --- a/drivers/i2c/busses/i2c-designware-amdisp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdisp.c
> @@ -18,9 +18,6 @@
>   static void amd_isp_dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *i2c_dev)
>   {
>          pm_runtime_disable(i2c_dev->dev);
> -
> -       if (i2c_dev->shared_with_punit)
> -               pm_runtime_put_noidle(i2c_dev->dev);
>   }
>
>   static inline u32 amd_isp_dw_i2c_get_clk_rate(struct dw_i2c_dev *i2c_dev)
> @@ -79,9 +76,6 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev)
>
>          device_enable_async_suspend(&pdev->dev);
>
> -       if (isp_i2c_dev->shared_with_punit)
> -               pm_runtime_get_noresume(&pdev->dev);
> -
>          pm_runtime_enable(&pdev->dev);
>          pm_runtime_get_sync(&pdev->dev);
>
> @@ -130,9 +124,6 @@ static int amd_isp_dw_i2c_plat_runtime_suspend(struct device *dev)
>   {
>          struct dw_i2c_dev *i_dev = dev_get_drvdata(dev);
>
> -       if (i_dev->shared_with_punit)
> -               return 0;
> -
>          i2c_dw_disable(i_dev);
>          i2c_dw_prepare_clk(i_dev, false);
>
> @@ -161,9 +152,7 @@ static int amd_isp_dw_i2c_plat_runtime_resume(struct device *dev)
>          if (!i_dev)
>                  return -ENODEV;
>
> -       if (!i_dev->shared_with_punit)
> -               i2c_dw_prepare_clk(i_dev, true);
> -
> +       i2c_dw_prepare_clk(i_dev, true);
>          i2c_dw_init(i_dev);
>
>          return 0;
> --
> 2.50.1
>