linux-kernel - Re: [PATCH] iio: light: apds9306: remove unused nlux_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be6e6492-b3f9-4a0b-87b6-3816eff6d395@tweaklogic.com>
Date: Fri, 30 Jan 2026 09:06:00 +1030
From: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Jagath Jog J <jagathjog1996@...il.com>,
 Eugene Zaikonnikov <ez@...phonic.com>,
 Marcelo Schmitt <marcelo.schmitt1@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: light: apds9306: remove unused nlux_per_count

On 30/1/26 04:12, Antoniu Miclaus wrote:
> Remove unused nlux_per_count field from apds9306_data
> struct. The field is declared but never accessed in the
> driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
>   drivers/iio/light/apds9306.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 7e68cca0edfa..ef6429bde193 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -168,7 +168,6 @@ struct apds9306_regfields {
>    *         respectively.
>    * @regmap: Regmap structure pointer
>    * @rf: Regmap register fields structure
> - * @nlux_per_count: Nano lux per ADC count for a particular model
>    * @read_data_available: Flag set by IRQ handler for ADC data available
>    */
>   struct apds9306_data {
> @@ -180,7 +179,6 @@ struct apds9306_data {
>   	struct regmap *regmap;
>   	struct apds9306_regfields rf;
>   
> -	int nlux_per_count;
>   	int read_data_available;
>   };
>   
Good find.

Acked-by: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>

Regards,
Subhajit Ghosh