linux-kernel - Re: [PATCH] iio: light: apds9306: remove redundant explicit pointer cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <531a0877-53a3-46b0-b365-93e0511bbe2e@tweaklogic.com>
Date: Fri, 30 Jan 2026 09:14:41 +1030
From: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
To: SAJJA EASWAR SAI <eshwarsajja20@...il.com>, jic23@...nel.org
Cc: dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, iryuken@...k.com
Subject: Re: [PATCH] iio: light: apds9306: remove redundant explicit pointer
 cast

On 30/1/26 07:34, SAJJA EASWAR SAI wrote:
> C allows implicit conversion from void * to struct apds9306_data *, so the
> explicit cast on 'ptr' is unnecessary. Removing it improves readability.
> 
> Signed-off-by: SAJJA EASWAR SAI <eshwarsajja20@...il.com>
> ---
>   drivers/iio/light/apds9306.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 7e68cca0e..5d18eabd9 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -1176,7 +1176,7 @@ static int apds9306_init_iio_gts(struct apds9306_data *data)
>   
>   static void apds9306_powerdown(void *ptr)
>   {
> -	struct apds9306_data *data = (struct apds9306_data *)ptr;
> +	struct apds9306_data *data = ptr;
>   	struct apds9306_regfields *rf = &data->rf;
>   	int ret;
>
Looks good. Thank you.

Acked-by: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>

Regards,
Subhajit Ghosh