linux-kernel - Re: [PATCH] selftests/liveupdate: add end to end test infrastructure and scripts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALzav=dKzsuZe=ZLfVg+ENVS0RbfN2jBcHEn+N5Jic=ykHLmWA@mail.gmail.com>
Date: Thu, 29 Jan 2026 14:51:17 -0800
From: David Matlack <dmatlack@...gle.com>
To: Mike Rapoport <rppt@...nel.org>
Cc: Jordan Richards <jordanrichards@...gle.com>, Pasha Tatashin <pasha.tatashin@...een.com>, 
	Pratyush Yadav <pratyush@...nel.org>, Shuah Khan <shuah@...nel.org>, Jason Miu <jasonmiu@...gle.com>, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/liveupdate: add end to end test infrastructure
 and scripts

On Tue, Jan 27, 2026 at 9:33 AM Mike Rapoport <rppt@...nel.org> wrote:
> On Thu, Jan 22, 2026 at 09:44:27PM +0000, Jordan Richards wrote:

> > diff --git a/tools/testing/selftests/liveupdate/.gitignore b/tools/testing/selftests/liveupdate/.gitignore
> > index 661827083ab6..7dc1e8aec44c 100644
> > --- a/tools/testing/selftests/liveupdate/.gitignore
> > +++ b/tools/testing/selftests/liveupdate/.gitignore
> > @@ -6,4 +6,6 @@
> >  !*.sh
> >  !.gitignore
> >  !config
> > +!config.aarch64
> > +!config.x86_64

This could be:

  !config.*

> >  !Makefile
>
> Hmm, I missed it when tools/testing/selftests/liveupdate/ was posted.
> I'm not a huge fun of negative logic in .gitignore.
> Why can't we just exclude the patterns we don't want to track?

I'm pretty sure this came from me. It's the pattern we use for VFIO
and KVM selftests .gitignore.

Positive logic requires updating .gitignore for every new executable
(every new selftest). Negative logic requires updating .gitignore for
every new one-off files that don't match the existing negative logic.
In my experience with selftests, the former happens more frequently
than the latter, so the negative logic is easier to maintain.